chore(deps): update devdependencies (major) #26
Conversation
|
renovate
bot
requested review from
Artmann,
andyjakubowski,
jamesbhobbs and
saltenasl
as code owners
📝 WalkthroughWalkthroughDevDependencies in package.json were bumped to new major versions: @typescript-eslint/eslint-plugin and @typescript-eslint/parser → ^8.x, css-loader → ^7.x, eslint → ^9.x, eslint-config-prettier → ^10.x, jest → ^30.x, mkdirp → ^3.x, npm-run-all2 → ^8.x, rimraf → ^6.x, source-map-loader → ^5.x, style-loader → ^4.x, stylelint → ^16.x and related stylelint packages (config-recommended → ^17.x, config-standard → ^39.x, stylelint-prettier → ^5.x). Public API and exported signatures remain unchanged. Possibly related PRs
Suggested reviewers
Pre-merge checks❌ Failed checks (1 warning)
✅ Passed checks (2 passed)
Comment |
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
renovate
bot
force-pushed
the
renovate/major-dev-dependencies
branch
from
f5765f3 to
a6fb720
Compare
There was a problem hiding this comment.
Actionable comments posted: 1
📜 Review details
Configuration used: CodeRabbit UI
Review profile: ASSERTIVE
Plan: Pro
📒 Files selected for processing (1)
package.json(1 hunks)
⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (1)
- GitHub Check: check_release
| "jest": "^30.0.0", | ||
| "mkdirp": "^3.0.0", | ||
| "npm-run-all2": "^8.0.0", |
There was a problem hiding this comment.
Align @types/jest with Jest 30
Jest is now ^30.0.0, but @types/jest stays on the 29.x line; TypeScript builds will pick up the 29.x typings and mis-declare globals. Bump the types package in lockstep with Jest (or remove it if you rely on the bundled types).
- "@types/jest": "^29.2.0",
+ "@types/jest": "^30.0.0",📝 Committable suggestion
‼️ IMPORTANT
Carefully review the code before committing. Ensure that it accurately replaces the highlighted code, contains no missing lines, and has no issues with indentation. Thoroughly test & benchmark the code to ensure it meets the requirements.
| "jest": "^30.0.0", | |
| "mkdirp": "^3.0.0", | |
| "npm-run-all2": "^8.0.0", | |
| "jest": "^30.0.0", | |
| "@types/jest": "^30.0.0", | |
| "mkdirp": "^3.0.0", | |
| "npm-run-all2": "^8.0.0", |
🤖 Prompt for AI Agents
In package.json around lines 86 to 88, @types/jest is still on the 29.x line
while jest is ^30.0.0 causing TypeScript to pick up mismatching globals; update
the @types/jest devDependency to the matching 30.x version (or remove the
explicit @types/jest dependency if you want to use Jest's bundled types), then
reinstall and regenerate the lockfile (npm install / yarn install) so the
lockfile reflects the change.
a255dc2 to
ea90776
Compare
|
renovate
bot
force-pushed
the
renovate/major-dev-dependencies
branch
3 times, most recently
from
f80a467 to
62e7655
Compare
There was a problem hiding this comment.
Actionable comments posted: 1
Caution
Some comments are outside the diff and can’t be posted inline due to platform limitations.
⚠️ Outside diff range comments (1)
package.json (1)
14-18: Declare Node/NPM engines to prevent accidental Node 16 installsAdd engines reflecting the new toolchain’s minimums.
"license": "BSD-3-Clause", + "engines": { + "node": ">=18.18", + "npm": ">=9" + }, "author": {
♻️ Duplicate comments (1)
package.json (1)
88-88: Align @types/jest with Jest 30 (or drop it if unneeded)Jest is ^30.0.0 while
@types/jestremains ^29.x. Update to 30.x or remove if relying on bundled types.- "@types/jest": "^29.2.0", + "@types/jest": "^30.0.0",Optionally verify whether Jest 30 bundles TS types:
Does Jest 30 bundle TypeScript types, making @types/jest unnecessary?Also applies to: 76-76
📜 Review details
Configuration used: CodeRabbit UI
Review profile: ASSERTIVE
Plan: Pro
📒 Files selected for processing (1)
package.json(1 hunks)
⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (1)
- GitHub Check: check_release
🔇 Additional comments (1)
package.json (1)
83-96: Verify Webpack/Node compatibility for loader/tooling majorscss-loader 7, style-loader 4, source-map-loader 5, rimraf 6, stylelint 16, husky 9 generally require Node >=18 and Webpack 5. Ensure:
- Your dev environment uses Node >=18 (CI and local).
- @jupyterlab/builder version used resolves to Webpack 5 compatible with these loaders.
renovate
bot
force-pushed
the
renovate/major-dev-dependencies
branch
2 times, most recently
from
b5d85aa to
bac4687
Compare
There was a problem hiding this comment.
Actionable comments posted: 1
♻️ Duplicate comments (1)
package.json (1)
76-88: Keep Jest types in lockstep with Jest 30
@types/jestis still ^29.2.0 whilejestis ^30.0.0. TypeScript will load the 29.x globals and diverge from Jest 30’s API. Please bump@types/jestto 30.x (or drop it if relying on Jest’s bundled types).
| "eslint": "^9.0.0", | ||
| "eslint-config-prettier": "^10.0.0", |
There was a problem hiding this comment.
ESLint 9 breaks with legacy package.json config
ESLint v9 only reads flat configs; with the current "eslintConfig"/"eslintIgnore" blocks, eslint . now runs with defaults and misses all project rules. Either migrate to eslint.config.js (flat configs, move ignores there) or stay on ESLint 8.x for now.
Also applies to: 133-182
🤖 Prompt for AI Agents
package.json lines 84-85 (and also lines 133-182) currently use the legacy
"eslintConfig"/"eslintIgnore" fields which ESLint v9 no longer supports; to fix,
either pin ESLint to the latest 8.x in package.json devDependencies (change
"eslint": "^9.0.0" to a compatible 8.x version and adjust lockfile) OR migrate
to the new flat config by adding an eslint.config.js at the project root
(convert existing settings from package.json "eslintConfig" into the flat config
format, move ignore patterns into an .eslintignore or into the new flat config
via overrides/ignores) and update any npm scripts that call eslint if needed;
apply the chosen approach consistently to the other package.json sections
referenced (lines 133-182).
ace3d5f to
b8aec01
Compare
renovate
bot
force-pushed
the
renovate/major-dev-dependencies
branch
5 times, most recently
from
180ddd9 to
5df1001
Compare
renovate
bot
force-pushed
the
renovate/major-dev-dependencies
branch
from
63778b3 to
c39c6f8
Compare
There was a problem hiding this comment.
Actionable comments posted: 2
Caution
Some comments are outside the diff and can’t be posted inline due to platform limitations.
⚠️ Outside diff range comments (1)
package.json (1)
76-76: Align @types/jest with Jest 30.Jest is now
^30.0.0but@types/jestremains^29.2.0. TypeScript will pick up mismatched typings.Apply this diff:
- "@types/jest": "^29.2.0", + "@types/jest": "^30.0.0",Then reinstall and regenerate lockfile.
This was flagged in prior reviews and remains unresolved.
Also applies to: 88-88
📜 Review details
Configuration used: CodeRabbit UI
Review profile: ASSERTIVE
Plan: Pro
📒 Files selected for processing (1)
package.json(1 hunks)
⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (1)
- GitHub Check: check_release
renovate
bot
force-pushed
the
renovate/major-dev-dependencies
branch
2 times, most recently
from
10f8763 to
d8ab73f
Compare
renovate
bot
force-pushed
the
renovate/major-dev-dependencies
branch
4 times, most recently
from
6316af6 to
4690d7c
Compare
There was a problem hiding this comment.
Actionable comments posted: 1
♻️ Duplicate comments (2)
package.json (2)
76-76: Jest types mismatch—TypeScript globals will be incorrect.
@types/jestis still^29.2.0(line 76) butjestis now^30.0.0(line 88). TypeScript will pick up mismatched type definitions for Jest globals.Before merge:
- Bump
@types/jestto^30.0.0to match jest, OR- Pin jest back to
^29.xand update this PRApply this diff to sync the versions:
- "@types/jest": "^29.2.0", + "@types/jest": "^30.0.0",Also applies to: 88-88
84-84: ⛔ ESLint 9 + legacy config still unresolved—linting will break.Prior review flagged that ESLint v9 ignores package.json's
eslintConfig/eslintIgnoreblocks (lines 133–142). Noeslint.config.jshas been created, and linting will use only defaults.Before merge, choose one:
- Create
eslint.config.jsat repo root with flat config format and migrate the rules/ignores from lines 133–185- OR pin ESLint back to
^8.57.0and revert this change
📜 Review details
Configuration used: CodeRabbit UI
Review profile: ASSERTIVE
Plan: Pro
Disabled knowledge base sources:
- Linear integration is disabled by default for public repositories
You can enable these sources in your CodeRabbit configuration.
📒 Files selected for processing (1)
package.json(1 hunks)
| "@typescript-eslint/eslint-plugin": "^8.0.0", | ||
| "@typescript-eslint/parser": "^8.0.0", | ||
| "css-loader": "^7.0.0", | ||
| "eslint": "^9.0.0", | ||
| "eslint-config-prettier": "^10.0.0", | ||
| "eslint-plugin-prettier": "^5.0.0", | ||
| "husky": "9.1.7", | ||
| "jest": "^29.2.0", | ||
| "jest": "^30.0.0", | ||
| "lint-staged": "16.2.3", | ||
| "mkdirp": "^1.0.3", | ||
| "npm-run-all2": "^7.0.1", | ||
| "mkdirp": "^3.0.0", | ||
| "npm-run-all2": "^8.0.0", | ||
| "prettier": "^3.0.0", | ||
| "rimraf": "^5.0.1", | ||
| "source-map-loader": "^1.0.2", | ||
| "style-loader": "^3.3.1", | ||
| "stylelint": "^15.10.1", | ||
| "stylelint-config-recommended": "^13.0.0", | ||
| "stylelint-config-standard": "^34.0.0", | ||
| "rimraf": "^6.0.0", | ||
| "source-map-loader": "^5.0.0", | ||
| "style-loader": "^4.0.0", | ||
| "stylelint": "^16.0.0", | ||
| "stylelint-config-recommended": "^17.0.0", | ||
| "stylelint-config-standard": "^39.0.0", | ||
| "stylelint-csstree-validator": "^3.0.0", | ||
| "stylelint-prettier": "^4.0.0", | ||
| "stylelint-prettier": "^5.0.0", |
There was a problem hiding this comment.
🧩 Analysis chain
Lockfile must be regenerated after major version bumps.
Fifteen packages jumped majors (source-map-loader 1→5, mkdirp 1→3, @typescript-eslint 6→8, stylelint 15→16, etc.). No lockfile changes detected in this PR.
Required before merge:
- Run
yarn install(ornpm install) to regenerate yarn.lock/package-lock.json - Run full CI locally:
yarn clean:all && yarn install && yarn build && yarn lint && yarn test - Commit updated lockfile and fix any breaking changes
- Verify no transitive dependency incompatibilities surface
Please confirm:
- Lockfile was regenerated and committed
- Full CI pipeline passes locally
- Any breaking changes from major upgrades have been resolved
Generate a script to verify lockfile was updated:
🏁 Script executed:
#!/bin/bash
# Check if lockfile was modified in the last commit
echo "=== Checking if lockfile was regenerated ==="
git diff --name-only HEAD~1 | grep -E 'yarn\.lock|package-lock\.json' && echo "✓ Lockfile updated" || echo "✗ Lockfile NOT updated"
# Show the last few lines of the changed lockfile
echo -e "\n=== Recent lockfile changes (last 20 lines) ==="
git diff HEAD~1 yarn.lock 2>/dev/null | tail -20 || git diff HEAD~1 package-lock.json 2>/dev/null | tail -20 || echo "No lockfile diff found"Length of output: 116
Lockfile not regenerated—blocking merge.
Verification confirms lockfile (yarn.lock/package-lock.json) was not updated despite 15 major version bumps. Regenerate lockfile and test:
yarn install && yarn clean:all && yarn install && yarn build && yarn lint && yarn testCommit the updated lockfile before proceeding.
🤖 Prompt for AI Agents
In package.json around lines 81–100 the dependency versions were bumped but the
lockfile was not regenerated; run the project's package manager to update the
lockfile (e.g., yarn install or npm install depending on repo), run the full
verification sequence provided (yarn install && yarn clean:all && yarn install
&& yarn build && yarn lint && yarn test), resolve any resulting
install/build/lint/test errors, and commit the updated lockfile (yarn.lock or
package-lock.json) alongside the change before merging.
f9dcbf3 to
2e2aef2
Compare
renovate
bot
force-pushed
the
renovate/major-dev-dependencies
branch
8 times, most recently
from
9895b42 to
4ddc478
Compare
There was a problem hiding this comment.
Actionable comments posted: 1
Caution
Some comments are outside the diff and can’t be posted inline due to platform limitations.
⚠️ Outside diff range comments (1)
package.json (1)
76-76: Sync @types/jest with Jest 30.
@types/jestis ^29.2.0 but jest is now ^30.0.0—TypeScript will see mismatched globals and type definitions. Bump @types/jest to ^30.0.0:- "@types/jest": "^29.2.0", + "@types/jest": "^30.0.0",Also applies to: 88-88
📜 Review details
Configuration used: CodeRabbit UI
Review profile: ASSERTIVE
Plan: Pro
Disabled knowledge base sources:
- Linear integration is disabled by default for public repositories
You can enable these sources in your CodeRabbit configuration.
📒 Files selected for processing (1)
package.json(1 hunks)
⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (1)
- GitHub Check: check_release
🔇 Additional comments (1)
package.json (1)
81-100: Lockfile already regenerated—review premise incorrect.The yarn.lock file exists and is in a clean state (working tree clean per git status), meaning package.json changes have already been followed by lockfile regeneration. While the 15 major version bumps are real (source-map-loader 1→5, @typescript-eslint 6→8, stylelint 15→16, eslint-config-prettier 8→10, etc.), the blocking condition cited in the review no longer applies. No further action needed on lockfile regeneration.
Likely an incorrect or invalid review comment.
| "@typescript-eslint/eslint-plugin": "^8.0.0", | ||
| "@typescript-eslint/parser": "^8.0.0", | ||
| "css-loader": "^7.0.0", | ||
| "eslint": "^9.0.0", |
There was a problem hiding this comment.
ESLint 9 migration requires flat config—linting will break.
ESLint v9 removed support for package.json eslintConfig/eslintIgnore blocks. Your current config (lines 133–142) will be ignored; linting falls back to defaults.
Choose one:
- Option A (preferred): Create
eslint.config.jsat repo root with flat config format. Migrate rules and ignores there, then remove legacy blocks from package.json. - Option B: Downgrade to
"eslint": "^8.57.0"and keep legacy config.
This must be resolved before merge.
Also applies to: 133-142
🤖 Prompt for AI Agents
package.json around line 84 (and legacy eslint blocks at lines 133–142): ESLint
v9 dropped package.json eslintConfig/eslintIgnore support so your current config
will be ignored; fix by either (A) creating an eslint.config.js at repo root
using the new flat config format, migrating all rules, parser/options, plugins
and ignore patterns from package.json to that file, remove the legacy
eslintConfig and eslintIgnore entries from package.json, and validate by running
eslint --print-config or a lint run; or (B) pin eslint back to a v8 release
(e.g. "eslint": "^8.57.0") in package.json to retain the legacy package.json
config — choose A (preferred) and remove the old blocks after migration.
e35a909 to
b126b8b
Compare
renovate
bot
force-pushed
the
renovate/major-dev-dependencies
branch
from
b126b8b to
7c04b17
Compare
This PR contains the following updates:
^6.1.0->^8.0.0^6.1.0->^8.0.0^6.7.1->^7.0.0^8.36.0->^9.0.0^8.8.0->^10.0.0^29.2.0->^30.0.0^1.0.3->^3.0.0^7.0.1->^8.0.0^5.0.1->^6.0.0^1.0.2->^5.0.0^3.3.1->^4.0.0^15.10.1->^16.0.0^13.0.0->^17.0.0^34.0.0->^39.0.0^4.0.0->^5.0.0Release Notes
typescript-eslint/typescript-eslint (@typescript-eslint/eslint-plugin)
v8.46.2Compare Source
🩹 Fixes
❤️ Thank You
You can read about our versioning strategy and releases on our website.
v8.46.1Compare Source
🩹 Fixes
.finallynot to report when a promise returning function is provided as an argument (#11667)❤️ Thank You
You can read about our versioning strategy and releases on our website.
v8.46.0Compare Source
🚀 Features
🩹 Fixes
export imports (#11603)this: voidand binding (#11634)❤️ Thank You
You can read about our versioning strategy and releases on our website.
v8.45.0Compare Source
🚀 Features
🩹 Fixes
❤️ Thank You
You can read about our versioning strategy and releases on our website.
v8.44.1Compare Source
🩹 Fixes
❤️ Thank You
You can read about our versioning strategy and releases on our website.
v8.44.0Compare Source
🚀 Features
🩹 Fixes
❤️ Thank You
You can read about our versioning strategy and releases on our website.
v8.43.0Compare Source
🚀 Features
🩹 Fixes
❤️ Thank You
You can read about our versioning strategy and releases on our website.
v8.42.0Compare Source
🩹 Fixes
You can read about our versioning strategy and releases on our website.
v8.41.0Compare Source
🩹 Fixes
You can read about our versioning strategy and releases on our website.
v8.40.0Compare Source
🚀 Features
EnumMember(#11232)❤️ Thank You
You can read about our versioning strategy and releases on our website.
v8.39.1Compare Source
This was a version bump only for eslint-plugin to align it with other projects, there were no code changes.
You can read about our versioning strategy and releases on our website.
v8.39.0Compare Source
🚀 Features
🩹 Fixes
unsafeObjectPatternmessage (#11403)checkoption for most RHS of a chain (#11272)❤️ Thank You
You can read about our versioning strategy and releases on our website.
v8.38.0Compare Source
🩹 Fixes
isolatedDeclarationsif enabled inconstructoroption (#11351)❤️ Thank You
You can read about our versioning strategy and releases on our website.
v8.37.0Compare Source
🩹 Fixes
❤️ Thank You
You can read about our versioning strategy and releases on our website.
v8.36.0Compare Source
This was a version bump only for eslint-plugin to align it with other projects, there were no code changes.
You can read about our versioning strategy and releases on our website.
v8.35.1Compare Source
🩹 Fixes
❤️ Thank You
You can read about our versioning strategy and releases on our website.
v8.35.0Compare Source
🚀 Features
❤️ Thank You
You can read about our versioning strategy and releases on our website.
v8.34.1Compare Source
This was a version bump only for eslint-plugin to align it with other projects, there were no code changes.
You can read about our versioning strategy and releases on our website.
v8.34.0Compare Source
🩹 Fixes
❤️ Thank You
You can read about our versioning strategy and releases on our website.
v8.33.1Compare Source
🩹 Fixes
❤️ Thank You
You can read about our versioning strategy and releases on our website.
v8.33.0Compare Source
This was a version bump only for eslint-plugin to align it with other projects, there were no code changes.
You can read about our versioning strategy and releases on our website.
v8.32.1Compare Source
🩹 Fixes
TSMappedTypewith no type annotation (#11180)❤️ Thank You
You can read about our versioning strategy and releases on our website.
v8.32.0Compare Source
🚀 Features
allowRethrowing(#11075)🩹 Fixes
thisfrom optional parameter overload check (#11005)❤️ Thank You
You can read about our versioning strategy and releases on our website.
v8.31.1Compare Source
🩹 Fixes
❤️ Thank You
You can read about our versioning strategy and releases on our website.
v8.31.0Compare Source
🚀 Features
❤️ Thank You
You can read about our versioning strategy and releases on our website.
v8.30.1Compare Source
🩹 Fixes
❤️ Thank You
You can read about our versioning strategy and releases on our website.
v8.30.0Compare Source
🚀 Features
🩹 Fixes
❤️ Thank You
You can read about our versioning strategy and releases on our website.
v8.29.1Compare Source
🩹 Fixes
❤️ Thank You
You can read about our versioning strategy and releases on our website.
v8.29.0Compare Source
🚀 Features
ignoreIfStatementsoption (#11000)🩹 Fixes
noUncheckedIndexedAccessis enabled (#10961)❤️ Thank You
You can read about our versioning strategy and releases on our website.
v8.28.0Compare Source
🚀 Features
ifstatement assignment (??=) and fix several minor bugs (#10861)🩹 Fixes
❤️ Thank You
You can read about our versioning strategy and releases on our website.
v8.27.0Compare Source
🚀 Features
DeprecatedInfoforrule.meta.deprecated(#10932)❤️ Thank You
You can read about our versioning strategy and releases on our website.
v8.26.1Compare Source
🩹 Fixes
any/unknownas eligible for nullish coalescing (#10865)❤️ Thank You
You can read about our versioning strategy and releases on our website.
v8.26.0Compare Source
🚀 Features
🩹 Fixes
accessorproperties with an invalidvoidtype (#10864)❤️ Thank You
You can read about our versioning strategy and releases on our website.
v8.25.0Compare Source
🚀 Features
🩹 Fixes
❤️ Thank You
You can read about our versioning strategy and releases on our website.
v8.24.1Compare Source
🩹 Fixes
accessormethods with a function initializer (#10796)staticaccessorproperties (#10814)accessorproperty declaration (#10813)accessorclass properties for missing accessibility modifier (#10805)accessorclass properties with a function initializer (#10804)accessorproperties with a function initializer (#10794)accessorclass properties (#10789)anyvalue assigned as an initializer of anaccessorproperty (#10785)❤️ Thank You
You can read about our versioning strategy and releases on our website.
v8.24.0Compare Source
🚀 Features
allowConstantLoopConditionsmore granular (#10639)🩹 Fixes
allowNumberAndStringisfalse(#10737)❤️ Thank You
You can read about our versioning strategy and releases on our website.
v8.23.0Compare Source
🚀 Features
🩹 Fixes
❤️ Thank You
You can read about our versioning strategy and releases on our website.
v8.22.0Compare Source
🩹 Fixes
❤️ Thank You
You can read about our versioning strategy and releases on our website.
v8.21.0Compare Source
🩹 Fixes
❤️ Thank You
You can read about our versioning strategy and releases on our website.
v8.20.0Compare Source
🚀 Features
🩹 Fixes
❤️ Thank You
You can read about our versioning strategy and releases on our website.
v8.19.1Compare Source
🩹 Fixes
declarekeyword (#10543)❤️ Thank You
You can read about our versioning strategy and releases on our website.
v8.19.0Compare Source
🚀 Features
🩹 Fixes
❤️ Thank You
You can read about our [versioning strategy](https://main--typescript-eslint.netlify.app/users/versionin
Configuration
📅 Schedule: Branch creation - "every weekend" (UTC), Automerge - At any time (no schedule defined).
🚦 Automerge: Disabled by config. Please merge this manually once you are satisfied.
♻ Rebasing: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox.
👻 Immortal: This PR will be recreated if closed unmerged. Get config help if that's undesired.
This PR was generated by Mend Renovate. View the repository job log.